Add log processing delay metric #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose a new metric ``napalm_logs_processing_delay`` that provides a (rough?) view on how long it takes a message to be processed through napalm-logs - from the moment the message is received, till published. This timing excludes the time spent effectively publishing (as it may depend of various external factors), but it includes the time spent in the internal queues.
|
This feels like a very useful metric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose a new metric
napalm_logs_processing_delaythat providesa (rough?) view on how long it takes a message to be processed through
napalm-logs - from the moment the message is received, till published.
This timing excludes the time spent effectively publishing (as it may
depend of various external factors), but it includes the time spent in
the internal queues.
Example:
I'm wondering whether it makes sense to have the labels from the publisher (i.e., have separate delay report for each distinct publisher). Or even have labels from the message type (e.g.,
napalm_logs_processing_delay{error='BGP_PREFIX_LIMIT_EXCEEDED'} 0.001567363739013671? Or not at all maybe... 🤔